Misc fixes to colourspace extension #171
Conversation
One in the example plug-in and another in the docs. Signed-off-by: John-Paul Smith <[email protected]> AcademySoftwareFoundation#168
Clarified some points around output colourspace selection. Signed-off-by: John-Paul Smith <[email protected]>
|
The documentation for kOfxImageClipPropColourspace might still be somewhat confusing. |
|
The documentation for kOfxImageClipPropColourspace might still be somewhat
confusing.
Maybe it should be more clear that the host will query this property
through kOfxImageEffectActionGetOutputColourspace and that the plugin may
set it on the output clip for its own internal purposes but that the host
will not check the property on the output clip.
Just been discussing that with J-P and Gary. I'd say no to both of those.
In my opinion the host should be the only thing that sets this property on
a clip. The kOfxImageEffectActionGetOutputColourspace call returns the
plugin's requested output colour space in the args, not as a property of
the clip itself.
|
Hosts are now required to set the output clip colourspace after calling kOfxImageEffectActionGetOutputColourspace. The comments now include situations where the output clip colourspace might be expected to change. Signed-off-by: John-Paul Smith <[email protected]>
This clarifies the presence of non-basic roles in the config header. They cannot be used in the basic style but are acceptable in the core style. Also corrected the invocation example in genColour and @file comment in the config header to match the new naming scheme. Signed-off-by: John-Paul Smith <[email protected]>
Signed-off-by: John-Paul Smith <[email protected]>
Thanks @Guido-assim, I've fixed that now. |
john-paulsmith
merged commit 7999342
into
AcademySoftwareFoundation:main
|
@john-paulsmith |
Some more uses of the misnamed property values have been corrected, and the docs around output clip colourspace have been improved.