deps: Add build recipe for WebP #4422
Draft
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
reviewed
Sep 14, 2024
Signed-off-by: Zach Lewis <[email protected]>
Signed-off-by: Zach Lewis <[email protected]>
…ation#4409) When I added perpixel_op recently, I didn't get the function signature right. It only would work for plain old function pointers, and would not work properly for "functors" or lambdas with capture. I should have used function_view which can do a light-weight wrapper of all three, so now I do. Also modified imagebufalgo_test to explicitly test all three forms to be sure they work. Also update function_view ever so slightly. --------- Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Zach Lewis <[email protected]>
With 3.0 approaching, it seems like the only time to make these changes that I made note of a while back: * It seems to me that `tell()` should be const because it isn't going to modify or change the state of the IOProxy. * It seems to me that `flush()` should NOT be const, because it probably does change internal state. Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Zach Lewis <[email protected]>
…oundation#4425) We no longer supply a FindOpenColorIO.cmake, so it makes no difference. But it was getting in the way of a weird case where a wrapping project wanted to supply one. Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Zach Lewis <[email protected]>
Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Zach Lewis <[email protected]>
…emySoftwareFoundation#4427) Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Zach Lewis <[email protected]>
zachlewis
force-pushed
the
build_WebP
branch
from
2e6dd17
to
0d17669
Compare
|
I'm worried that the failure of the Windows CI tests is related to this somehow. DLL not in the right place, something like that? |
|
@zachlewis What's the current status of this one? |
|
Help needed. I don't have a way of testing this locally, and I can't really tell what's going wrong from the logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #4387.