[2057] - Fix views/display submenus in OCIODisplay app #2068
Conversation
Signed-off-by: Hannah <[email protected]>
|
There was a problem hiding this comment.
Thanks for this contribution Hannah!
Apologies for the delayed review, things have been very busy. Just one minor request below.
Minor issue, but I'm noticing a large number of white space changes. Not sure if that was you or you have an auto-formatter turned on. Although the changes are not bad, we generally don't like people to reformat white space in areas of the code they are not modifying. It makes the PR more difficult to review and it makes the git blame history of the file harder to follow. I won't ask you to waste your time reverting the changes, but please keep it in mind for future contributions.
| float g_exposure_fstop{0.0f}; | ||
| float g_display_gamma{1.0f}; | ||
| int g_channelHot[4]{1, 1, 1, 1}; // show rgb | ||
| int viewsMenuID; |
There was a problem hiding this comment.
The other global variables have a "g_" prefix, please follow that style.
This fixes the bug where the "Views" submenu (renamed from "Transform") doesn't update when a new "Display" is chosen (renamed submenu from "Device").
#2057