Skip to content

Commit

Permalink
Errata Update: Relaxation of Rules (#492)
Browse files Browse the repository at this point in the history
- MSI/MSI-X not made mandatory for RP hence test
  will continue checking for other devices if
  MSI/MSI-X not supported
- PCI_ER_02 and PCI_ER_03 removed

Signed-off-by: Sujana M <[email protected]>
  • Loading branch information
Sujana-M authored Oct 19, 2024
1 parent f04c500 commit 511f139
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docs/arm_sbsa_testcase_checklist.rst
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ The below table provides the following details
+-------+--------------------------------------------+-----+----------------------------------------------------+----------------+----+----------+-----+-------------------+
|905 |PE 2/4/8B writes tp PCIe as 2/4/8B |L7 |S_PCIe_03 |No |Yes |Yes |No |Yes |
+-------+--------------------------------------------+-----+----------------------------------------------------+----------------+----+----------+-----+-------------------+
|906 |RP's must support AER feature |L7 |PCI_ER_01, PCI_ER_02, PCI_ER_03, PCI_ER_04 |No |Yes |Yes |No |Yes |
|906 |RP's must support AER feature |L7 |PCI_ER_01, PCI_ER_04 |No |Yes |Yes |No |Yes |
+-------+--------------------------------------------+-----+----------------------------------------------------+----------------+----+----------+-----+-------------------+
|907 |RP's must support DPC |L7 |PCI_ER_05, PCI_ER_06 |No |Yes |Yes |No |Yes |
+-------+--------------------------------------------+-----+----------------------------------------------------+----------------+----+----------+-----+-------------------+
Expand Down
9 changes: 4 additions & 5 deletions test_pool/exerciser/operating_system/test_e006.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

#define TEST_NUM (ACS_EXERCISER_TEST_NUM_BASE + 6)
#define TEST_DESC "RP's must support AER feature "
#define TEST_RULE "PCI_ER_01, PCI_ER_02, PCI_ER_03, PCI_ER_04"
#define TEST_RULE "PCI_ER_01, PCI_ER_04"

#define ERR_CORR 0x2
#define ERR_UNCORR 0x3
Expand Down Expand Up @@ -335,14 +335,13 @@ payload(void)

/* Search for MSI-X Capability */
if (val_pcie_find_capability(e_bdf, PCIE_CAP, CID_MSIX, &msi_cap_offset)) {
val_print(ACS_PRINT_ERR, "\n No MSI-X Capability, Skipping for Bdf 0x%x", e_bdf);
val_print(ACS_PRINT_DEBUG, "\n No MSI-X Capability, Skipping for Bdf 0x%x", e_bdf);
continue;
}

if (val_pcie_find_capability(erp_bdf, PCIE_CAP, CID_MSIX, &msi_cap_offset)) {
val_print(ACS_PRINT_ERR, "\n No MSI-X Capability for RP Bdf 0x%x", erp_bdf);
val_set_status(pe_index, RESULT_FAIL(TEST_NUM, 01));
return;
val_print(ACS_PRINT_DEBUG, "\n No MSI-X Capability for RP Bdf 0x%x", erp_bdf);
continue;
}

/* Get DeviceID & ITS_ID for this device */
Expand Down

0 comments on commit 511f139

Please sign in to comment.