Add int8 padding operator and unit tests #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansnils
reviewed
Oct 15, 2024
README.md
Outdated
| @@ -38,6 +38,7 @@ Examples are Cortex-M55 or Cortex-M85 configured with MVE. | |||
| | Softmax | Yes | Yes | N/A | Yes | Yes | N/A | Yes | No | N/A | | |||
| | LSTM | Yes | Yes | No | Yes | Yes | No | Yes | Yes | No | | |||
| | SVDF | Yes | No | No | Yes | No | No | Yes | No | No | | |||
| | Pad | Yes | No | No | Yes | No | No | Yes | No | No | | |||
There was a problem hiding this comment.
Should this be N/A instead of No as no weights
There was a problem hiding this comment.
I think no is the right one here, because it is possible to have int16 padding for example but we do not have the support for it? It seems like this table is not intended for weights but rather base operator support. I would personally argue that we should replace all N/A with no
There was a problem hiding this comment.
int16 padding would mean input and output in int16, right? That is second column with a No already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.