fix: bug in AVL tree delete

4ndrelim · Apr 29, 2024 · 19dabf2 · 19dabf2
1 parent 37c99e3
commit 19dabf2
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/main/java/dataStructures/avlTree/AVLTree.java b/src/main/java/dataStructures/avlTree/AVLTree.java
@@ -226,7 +226,6 @@ private Node<T> delete(Node<T> node, T key) {
             node.setLeft(delete(node.getLeft(), key));
         } else {
             if (node.getLeft() == null || node.getRight() == null) { // case of 1 or 0 child
-                // node = node.left == null ? node.right : node.left;
                 if (node.getLeft() == null && node.getRight() == null) {
                     node = null; // 0-child case
                 } else if (node.getRight() == null) {
@@ -245,10 +244,10 @@ private Node<T> delete(Node<T> node, T key) {
             }
         }
 
-        if (node != null) { // make sure it isnt the 0-child case
-            rebalance(node);
+        if (node != null) { // make sure it isn't the 0-child case
+            return rebalance(node);
         }
-        return node;
+        return node; // null; case when nothing left
     }
 
     /**