Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main repo directory as root for all assets #5

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

pietrushnic
Copy link
Member

@pietrushnic pietrushnic commented Sep 30, 2023

I'm using a structure with assumptions about remark-remplate and img in the root directory in Dasharo/presentations, and it works very well. As additional benefit image paths are correctly identified by GitHub (because GH seems to understand / but not ../.. construction). As next step regarding improvements with this PR we could address #6

Signed-off-by: Piotr Król <[email protected]>
Copy link
Member

@macpijan macpijan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation template still works for me. LGTM.

@macpijan macpijan merged commit 6c65bff into master Oct 2, 2023
@macpijan macpijan deleted the improve-usability branch October 2, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants