Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate flash.sh from RteCtrl #83

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Integrate flash.sh from RteCtrl #83

merged 3 commits into from
Nov 25, 2024

Conversation

DaniilKl
Copy link
Contributor

@DaniilKl DaniilKl commented Nov 7, 2024

For more inf.:
3mdeb/RteCtrl#22
#80

Add flash.sh script from 3mdeb/RteCtrl#22.
For more inf. check #80.

Signed-off-by: Daniil Klimuk <[email protected]>
@DaniilKl DaniilKl self-assigned this Nov 7, 2024
@DaniilKl DaniilKl marked this pull request as ready for review November 7, 2024 16:17
@DaniilKl DaniilKl force-pushed the integrate-flash-script branch from 3709f78 to c4c0f2b Compare November 7, 2024 16:19
@DaniilKl DaniilKl linked an issue Nov 7, 2024 that may be closed by this pull request
4 tasks
@DaniilKl DaniilKl force-pushed the integrate-flash-script branch from c4c0f2b to b09e9b7 Compare November 8, 2024 15:40
@DaniilKl DaniilKl requested a review from macpijan November 8, 2024 15:41
Copy link

@wessel-novacustom wessel-novacustom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macpijan

flashrom -p "$FLASHROM_PROGRAMMER" "$FLASHROM_PARAMS"

Is wrong.

It results in:

root@rte:~# ./flash.sh -V 3.3V probe
Setting SPI VCC to 3.3V
SPI lines ON
SPI Vcc ON
Probing ...
flashrom 1.4.0 on Linux 6.6.28 (armv7l)
flashrom is free software, get the source code at https://flashrom.org

Error: Extra parameter found.
Please run "flashrom --help" for usage info.
SPI Vcc OFF
SPI lines OFF


The fix would be:

flashrom -p "$FLASHROM_PROGRAMMER" $FLASHROM_PARAMS

So without the double quotes for the flashrom params.


I just made that change and tried:

root@rte:~# ./flash.sh -V 3.3V probe --flashrom-params "-o output.txt"

And that generated the output.txt file correctly, meaning that the flashrom params are still working, while now also without flashrom params.

@DaniilKl
Copy link
Contributor Author

Thank you for your feedback. Fixed here ffda849.

@macpijan
Copy link
Member

This script will be available in the future releases of RTE OS image

@macpijan macpijan merged commit ffda849 into master Nov 25, 2024
1 check passed
@macpijan macpijan deleted the integrate-flash-script branch November 25, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate flash.sh script into image
3 participants