Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC721 and ERC1155 support #14

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

k06a
Copy link
Member

@k06a k06a commented Nov 23, 2022

No description provided.

@k06a k06a requested a review from ZumZoom November 23, 2022 13:15
Base automatically changed from fix/reentrancy to master November 24, 2022 08:52
@ZumZoom ZumZoom changed the base branch from master to develop November 24, 2022 09:04
@ZumZoom ZumZoom changed the base branch from develop to master November 24, 2022 09:06
@ZumZoom ZumZoom marked this pull request as draft November 24, 2022 09:17
ZumZoom and others added 3 commits November 24, 2022 13:21
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Base: 100.00% // Head: 64.77% // Decreases project coverage by -35.22% ⚠️

Coverage data is based on head (ded86e3) compared to base (9a3e4f7).
Patch coverage: 54.74% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##            master      #14       +/-   ##
============================================
- Coverage   100.00%   64.77%   -35.23%     
============================================
  Files            3        6        +3     
  Lines           98      176       +78     
  Branches        20       33       +13     
============================================
+ Hits            98      114       +16     
- Misses           0       62       +62     
Impacted Files Coverage Δ
contracts/ERC1155Pods.sol 0.00% <0.00%> (ø)
contracts/ERC721Pods.sol 0.00% <0.00%> (ø)
contracts/Pod.sol 61.53% <28.57%> (-38.47%) ⬇️
contracts/TokenPodsLib.sol 96.96% <96.96%> (ø)
contracts/ERC20Pods.sol 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@k06a k06a force-pushed the feature/erc721-erc1155 branch 2 times, most recently from 3b1b7f0 to 1b2e6d2 Compare December 20, 2022 20:49
# Conflicts:
#	contracts/Pod.sol
#	contracts/interfaces/IPod.sol
#	contracts/mocks/PodMock.sol
#	contracts/mocks/WrongPodMock.sol
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants