Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG-14261 Add attempt count to mfa setup auth events #11293

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

LG-14261 Add attempt count to mfa setup auth events #11293

wants to merge 45 commits into from

Commits on Oct 17, 2024

  1. changelog: Internal, MFA setup, Add attempt count to MFA setup analyt… 

    …ics event
    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    76dcf08 View commit details
    Browse the repository at this point in the history

  2. add piv attempts, use common name in analytics

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c6402f9 View commit details
    Browse the repository at this point in the history

  3. add logging to otp and totp setup

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    ca53ef1 View commit details
    Browse the repository at this point in the history

  4. reset attempts count on success

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6542fe3 View commit details
    Browse the repository at this point in the history

  5. add totp reset and refactor reset on webauthn

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    587da36 View commit details
    Browse the repository at this point in the history

  6. update otp specs

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    ce6927a View commit details
    Browse the repository at this point in the history

  7. update totp specs

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a5b8825 View commit details
    Browse the repository at this point in the history

  8. update piv_cac_setup specs

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    afb95c5 View commit details
    Browse the repository at this point in the history

  9. add otp spec that confirms incremented mfa_attempts analytics log

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f9e035d View commit details
    Browse the repository at this point in the history

  10. add specs for piv and totp

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    563173a View commit details
    Browse the repository at this point in the history

  11. refactor slightly session key setter

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c93c566 View commit details
    Browse the repository at this point in the history

  12. add testing for attempts on webauthn setup

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    34cc178 View commit details
    Browse the repository at this point in the history

  13. refactor pulling commonly use function into mfa setup concern

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    34f553c View commit details
    Browse the repository at this point in the history

  14. move mfa attempts to 2fa methods concern, change to user_session

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    73ecdc8 View commit details
    Browse the repository at this point in the history

  15. equip otp with mfa attempt logging at authentication

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    45fd975 View commit details
    Browse the repository at this point in the history

  16. update spec because of session token change, add attempt count to web… 

    …authn verification
    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    8dd9cd6 View commit details
    Browse the repository at this point in the history

  17. add mfa attempt count for totp authentication

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    961f06b View commit details
    Browse the repository at this point in the history

  18. add mfa count for piv authentication

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    ff1564c View commit details
    Browse the repository at this point in the history

  19. clear user_session token when changing mfa after a failed attempt

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c5d3fbe View commit details
    Browse the repository at this point in the history

  20. add params to piv analytics event

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    0572f73 View commit details
    Browse the repository at this point in the history

  21. fix piv verification spec. reset mfa account for setup failure

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    d5a4d20 View commit details
    Browse the repository at this point in the history

  22. express auth attempts as a hash consisting of attempt count and method

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    54f296b View commit details
    Browse the repository at this point in the history

  23. group all attempts into a hash

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f57e9cd View commit details
    Browse the repository at this point in the history

  24. sync rspec up with changes made

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a692ecf View commit details
    Browse the repository at this point in the history

  25. add mfa attempt to event expectation

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    ab1fe0e View commit details
    Browse the repository at this point in the history

  26. add mfa attempt to event expectation

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    5d92095 View commit details
    Browse the repository at this point in the history

  27. fixes specs to catch missing events

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    25a70ff View commit details
    Browse the repository at this point in the history

  28. fix webauthn spec to correct user flow

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c6f08f0 View commit details
    Browse the repository at this point in the history

  29. fix mfa label in spec

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a97a0ac View commit details
    Browse the repository at this point in the history

  30. remove private_key gsub

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    02ec7f7 View commit details
    Browse the repository at this point in the history

  31. leverage symbols for mfa methods, remove no longer needed method from… 

    … prev iteration
    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    097a114 View commit details
    Browse the repository at this point in the history

  32. revise spec to use symbol

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    1dcea81 View commit details
    Browse the repository at this point in the history

  33. address keypath warnings from spec

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e1ae532 View commit details
    Browse the repository at this point in the history

  34. fix how otp verification controller generates the attempts count, upd… 

    …ate specs to sync with that
    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    9500700 View commit details
    Browse the repository at this point in the history

  35. gsub personal_key for mfa_attempts

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    1800e9b View commit details
    Browse the repository at this point in the history

  36. convert to sym

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    39b18a9 View commit details
    Browse the repository at this point in the history

  37. convert key to sym with correct method

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6528f70 View commit details
    Browse the repository at this point in the history

  38. rename incrementing method param. repair rspec to correct exptected mfa

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    1f9ae4c View commit details
    Browse the repository at this point in the history

  39. fix rspec expected mfa types

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    da9afdf View commit details
    Browse the repository at this point in the history

  40. place gsub behind a conditional

    @kevinsmaster5
    kevinsmaster5 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    65f3232 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. set up a programmatic way of protecting pii keys in sessions

    @kevinsmaster5
    kevinsmaster5 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b92b9a6 View commit details
    Browse the repository at this point in the history

  2. refactor increment verb

    @kevinsmaster5
    kevinsmaster5 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b9b2843 View commit details
    Browse the repository at this point in the history

  3. fix broken logic

    @kevinsmaster5
    kevinsmaster5 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ee762d5 View commit details
    Browse the repository at this point in the history

  4. put expected attempt key back

    @kevinsmaster5
    kevinsmaster5 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7a58848 View commit details
    Browse the repository at this point in the history

  5. add testing for change to session_encryptor

    @kevinsmaster5
    kevinsmaster5 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2f17d79 View commit details
    Browse the repository at this point in the history