-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TECH] Suppression de l'ancien design des pages d'authentification (PIX-15327) #10658
Open
bpetetot
wants to merge
14
commits into
dev
Choose a base branch
from
pix-15327-remove-old-authentication-design
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+245
−4,196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
bpetetot
force-pushed
the
pix-15327-remove-old-authentication-design
branch
2 times, most recently
from
November 30, 2024 17:32
17e8b82
to
1bdaa41
Compare
bpetetot
force-pushed
the
pix-15327-remove-old-authentication-design
branch
from
December 2, 2024 09:32
1bdaa41
to
7d1f597
Compare
bpetetot
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍂 Problème
Le nouveau design des pages d'authentification est en production depuis plusieurs semaines, il est temps de supprimer l'ancien design et le feature toggle associé.
🌰 Proposition
Suppression du code:
FT_NEW_AUTHENTICATION_DESIGN_ENABLED
(côté API et mon-pix)🎃 Remarques
Quand la PR sera mergée en production, supprimer la variable d’environnement
FT_NEW_AUTHENTICATION_DESIGN_ENABLED
sur les différents environnements : recette, production🪵 Pour tester
Vérifier le design et le comportement des pages d'authentification: