Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the help_text id attribute to the field aria-describedby #716

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

francoisfreitag
Copy link
Contributor

Otherwise, the rendered HTML does contains an aria-describedby that references a nonexistent element.

Otherwise, the rendered HTML does contains an `aria-describedby` that
references a nonexistent element.
@francoisfreitag
Copy link
Contributor Author

I pushed an update to reset the changelog to the wording on the main branch. The text on this branch was: Drop support for Python 3.8 (EOL) (#718). in case it’s still helpful.

@dyve dyve merged commit 3e59647 into zostera:main Dec 10, 2024
22 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12254074943

Details

  • 6 of 14 (42.86%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 96.708%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/test_bootstrap_form.py 1 2 50.0%
tests/test_bootstrap_field.py 3 10 30.0%
Totals Coverage Status
Change from base Build 12253674226: -0.6%
Covered Lines: 1367
Relevant Lines: 1400

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants