Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio select option disabled #632

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

xavfernandez
Copy link
Contributor

Match current behavior of Django's RadioSelect widget which allow to customize individual options' attrs (including disabled in a ChoiceField).

The create_option hook is documented in Django https://docs.djangoproject.com/en/5.0/ref/forms/fields/ to allow the customization of the different options rendering.

Copy link
Contributor

@francoisfreitag francoisfreitag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

tests/test_bootstrap_field_radio_select.py Outdated Show resolved Hide resolved
@xavfernandez xavfernandez force-pushed the radio_select_option_disabled branch from 2437f54 to 7312730 Compare July 3, 2024 15:12
@xavfernandez xavfernandez force-pushed the radio_select_option_disabled branch from 7312730 to 8d78e72 Compare July 4, 2024 09:47
@dyve dyve merged commit 264b376 into zostera:main Dec 10, 2024
22 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12254128369

Details

  • 28 of 28 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 96.772%

Totals Coverage Status
Change from base Build 12254114206: 0.06%
Covered Lines: 1395
Relevant Lines: 1428

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants