-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(talk): preserve whitespace in markdown code blocks #7106
base: master
Are you sure you want to change the base?
fix(talk): preserve whitespace in markdown code blocks #7106
Conversation
Test cases here: https://master.pfe-preview.zooniverse.org/talk/38/372?env=staging |
The original Planet Four comment, to test for regressions (and comments accidentally being displayed as code): https://www.zooniverse.org/projects/mschwamb/planet-four-terrains/talk/29/3494/?comment=6783 |
b3f2e97
to
2039229
Compare
31a6555
to
08307f6
Compare
A Talk comment with a Python script, that I just posted. This PR should fix the broken indentation here: |
eb2fbbe
to
cd256d2
Compare
6826c93
to
5c3a8bc
Compare
5c3a8bc
to
5a54cfb
Compare
Style Markdown code blocks so that long lines wrap without collapsing whitespace.
5a54cfb
to
57afb1e
Compare
Style Markdown code blocks so that long lines wrap without collapsing whitespace.
Trim comments so that comments with leading whitespace aren't accidentally displayed as code blocks.
pre-wrap
, notpre-line
.Test cases to run locally:
https://local.zooniverse.org:3735/projects/mschwamb/planet-four-terrains/talk/29/3494/?comment=6783&env=production&page=1
https://local.zooniverse.org:3735/talk/38/372
https://local.zooniverse.org:3735/talk/18/3317233?comment=5524608&env=production
Talk discussions:
Required Manual Testing
Review Checklist
npm ci
and app works as expected?Optional
ChangeListener
orPromiseRenderer
components with code that updates component state?