You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In src/zhinst/toolkit/resources/ct_schema_hdawg.json, all boolean value entries with default values are give a string default value, such as "false", which quotation marks should not be there. It is not checked if this is also present on other JSON schema files.
How to reproduce
Environment info
Python version:
zhinst-toolkit version:
LabOne version:
zhinst version:
Device/system information (if applicable)
Additional information
The text was updated successfully, but these errors were encountered:
I agree that this is a bug, the default value should be a boolean value, not a string.
The command table comes directly from the firmware of the device (dev8123/awgs/n/commandtable/schema). The hard-coded ones are just for legacy, since the device only exposes them since LabOne 22.08.
In any case, we should fix both, and I will forward this issue to our hardware team so that they can fix the one on the device for the next release (end of June).
Description
In
src/zhinst/toolkit/resources/ct_schema_hdawg.json
, all boolean value entries with default values are give a string default value, such as"false"
, which quotation marks should not be there. It is not checked if this is also present on other JSON schema files.How to reproduce
Environment info
Device/system information (if applicable)
Additional information
The text was updated successfully, but these errors were encountered: