Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - Use amplitude matrix for phases in command table #49

Open
GlaserN opened this issue Sep 22, 2023 · 1 comment
Open

[Feature] - Use amplitude matrix for phases in command table #49

GlaserN opened this issue Sep 22, 2023 · 1 comment
Labels
enhancement New feature or request jira Sync the issue to ZI LabOneQ internal issue tracker.

Comments

@GlaserN
Copy link

GlaserN commented Sep 22, 2023

For measurements were the phase of the pulses is changed throughout the sweep, e.g., ramseys, the L1Q generates individual modulated waves, which are uploaded to the device. This may lead to an overflow in waveform memory on the SGs. The command table commands include the definition of the oscillator gain matrix, which could be directly used to implement the phase of the played waveform.

Describe the solution you'd like
The phase of the waveform should be encoded in the command table entry, instead of the waveform itself.

Describe alternatives or workarounds you have considered

Context
Add any other context or screenshots about the feature request here.
L1Q-20230922_00064_ramsey_xy-20230922T153355Z-00000.zip

@polw-zi
Copy link
Contributor

polw-zi commented Sep 25, 2023

Hi @GlaserN, thanks for reaching out.

We currently intentionally do not use the command table to encode the phase for general pulses, as there are some corner cases where this can lead to conflicts and potentially incorrect programs. (That is not to say our compiler can't be made any smarter in the future.)

Nevertheless, increment_oscillator_phase already does directly use the command table's phase offset register. I understand it is less convenient, but is that a feasible workaround at all?

@kshirer kshirer added jira Sync the issue to ZI LabOneQ internal issue tracker. enhancement New feature or request labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jira Sync the issue to ZI LabOneQ internal issue tracker.
Projects
None yet
Development

No branches or pull requests

3 participants