Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remark-abbr to work with remark@next #516

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

Update remark-abbr to work with remark@next #516

wants to merge 4 commits into from

Commits on Nov 9, 2024

  1. Add micromark-extension-abbr 

    This is basically the same as the version in
https://github.com/richardTowers/remark-abbr, except I've converted the
tests from node:test to jest to be consistent with the rest of
zmarkdown.

This only exports a syntax extension - there's no HTML extension
(because micromark doesn't currently support the hooks we'd need to
implement one - see https://github.com/orgs/micromark/discussions/181
for more detail). It's only intended to be used in remark-abbr.
    @richardTowers
    richardTowers committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    c65a638 View commit details
    Browse the repository at this point in the history

  2. Implement remark-abbr and update tests 

    This implementation is pretty much taken verbatim from
https://github.com/richardTowers/remark-abbr. I didn't make much of an
attempt to merge it with the existing code.

The existing test suite is retained, and I haven't moved any of the
tests over from richardTowers/remark-abbr yet.

A couple of the snapshots needed to be updated, but in my view what the
code does now is more correct than what was happening before, so I think
they're okay.

I haven't implemented the expandFirst functionality just yet.
    @richardTowers
    richardTowers committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    02b4aaa View commit details
    Browse the repository at this point in the history

  3. Add support for expandFirst

    @richardTowers
    richardTowers committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    3000ad2 View commit details
    Browse the repository at this point in the history

  4. Run npm i

    @richardTowers
    richardTowers committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    272201f View commit details
    Browse the repository at this point in the history