Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose swagger parser errors as violations #1385

Open
tkrop opened this issue Apr 25, 2022 · 0 comments
Open

Expose swagger parser errors as violations #1385

tkrop opened this issue Apr 25, 2022 · 0 comments
Labels
area: server Zally server issues

Comments

@tkrop
Copy link
Member

tkrop commented Apr 25, 2022

Zally is missing to expose the swagger-parser errors and silently succeeding instead of failing with violations. The swagger-parser creates a number of failure messages when discovering syntax errors. These are silently ignored, when an API is linted (see DefaultContextFactory.kt#L111). Instead we should convert them into violations of rule #101 (see also DefaultContextFactory.kt#L108).

This is a bit tricky since we need to refactor the error model used distinguish between OpenAPI 3.0 and Swagger 2.0.

@tkrop tkrop added the area: server Zally server issues label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: server Zally server issues
Projects
None yet
Development

No branches or pull requests

1 participant