Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve]: GET_STARTED.md の内容を充実させる #332

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

nerd0geek1
Copy link
Collaborator

@nerd0geek1 nerd0geek1 commented Nov 5, 2024

概要

#289

チケットに記載があったアプローチとは違いますが、
mason / melosのグローバル化を行ったDart SDKのバージョンと
プロジェクトとのバージョン差異が問題の原因であるならば、
バージョンを揃えるために、fvmを噛ませたほうが良いのでは?という考えのもと、
fvmベースで動作確認などを行い、日本語ドキュメントを更新しました。

レビュー観点

レビューレベル

  • Lv1: ぱっとみて違和感がないかチェックして Approve する
  • Lv2: 仕様レベルまで理解して、仕様通りに動くかある程度検証して Approve する
  • Lv3: 実際に環境で動作確認したうえで Approve する

レビュー優先度

  • すぐに見てもらいたい ( hotfix など ) 🚀
  • 今日中に見てもらいたい 🚗
  • 今日〜明日中で見てもらいたい 🚶
  • 数日以内で見てもらいたい 🐢

画像 / 動画

Before After Design

確認したこと

動作確認手順

備考

Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nerd0geek1
いくつかコメントさせていただきましたのでご確認お願いします 🙏

docs/ja/GET_STARTED.md Outdated Show resolved Hide resolved
docs/ja/GET_STARTED.md Show resolved Hide resolved
docs/ja/GET_STARTED.md Outdated Show resolved Hide resolved
docs/ja/GET_STARTED.md Outdated Show resolved Hide resolved
docs/ja/GET_STARTED.md Outdated Show resolved Hide resolved
@nerd0geek1 nerd0geek1 force-pushed the feature/289 branch 2 times, most recently from ccbb255 to 0544966 Compare November 6, 2024 05:05
Copy link

github-actions bot commented Nov 6, 2024

Visit the preview URL for this PR (updated for commit 5c0906e):

https://flutter-mobile-project-template-catalog--pr332-feature-blf88q1g.web.app

(expires Thu, 14 Nov 2024 08:27:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 9ea56735a63d07a7cfe62eb204b0528284c37c23

@nerd0geek1 nerd0geek1 marked this pull request as ready for review November 6, 2024 05:26
@yumemi-team-review-requester yumemi-team-review-requester bot requested review from a team, rizumita and blendthink and removed request for a team November 6, 2024 05:26
Copy link

github-actions bot commented Nov 6, 2024

Ready for review 🚀

docs/ja/GET_STARTED.md Outdated Show resolved Hide resolved
Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございました!
LGTM です!

@blendthink blendthink merged commit a5f2626 into main Nov 7, 2024
12 checks passed
@blendthink blendthink deleted the feature/289 branch November 7, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants