add CSRF validation by custom HTTP header #20280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
olegbaturin
commented
Nov 23, 2024
olegbaturin
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
| Fixed issues | #20279 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20280 +/- ##
=========================================
Coverage 64.84% 64.85%
- Complexity 11399 11402 +3
=========================================
Files 430 430
Lines 37134 37140 +6
=========================================
+ Hits 24080 24086 +6
Misses 13054 13054 ☔ View full report in Codecov by Sentry. |
|
This is backport from Yii3. Good one. |
samdark
approved these changes
Nov 24, 2024
Arhell
approved these changes
Nov 25, 2024
bizley
requested changes
Nov 27, 2024
|
I think this PR is good with exception of typos as pointed out by @bizley |
bizley
approved these changes
Nov 28, 2024
|
@olegbaturin thanks for your time and efforts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.