Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excessive excludes for duplicate finder #1261

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MikailBag
Copy link
Contributor

@MikailBag MikailBag commented Apr 28, 2024

Changes in this PR:

  • Do not add module-info.class and related items to skiplist, because they are already skiplisted
  • Remove duplicatefinder: wildcard suppression from qulice-checkstyle and qulice-maven-plugin modules (which completely disables check)
  • Explicitly replace some aether-* packages with maven-resolver-* ones (according to https://maven.apache.org/aether.html, former are legacy anyway) (manual testing did not show other violations)

Unfortunately this PR can be neither tested or merged until next qulice-maven-plugin release (with updated duplicate-finder-maven-plugin)

@MikailBag MikailBag marked this pull request as draft April 28, 2024 18:42
@MikailBag MikailBag changed the title remove exclusion Prepare for next qulice-maven-plugin release Apr 28, 2024
@MikailBag
Copy link
Contributor Author

Update: according to manual local testing, these changes should be enough

@pnatashap
Copy link
Contributor

@MikailBag FYI next release was released

@MikailBag
Copy link
Contributor Author

@pnatashap Thank you for information. I updated PR and now it's green.

There is one strange part though. I had to add

                <exclude>dependencies:org.apache.maven.resolver:maven-resolver-api</exclude>
                <exclude>dependencies:org.apache.maven.resolver:maven-resolver-util</exclude>

because they are reported unused, but without them build fails with org.apache.maven.plugin.PluginExecutionException: Execution jcabi-qulice-check of goal com.qulice:qulice-maven-plugin:1.0-SNAPSHOT:check failed: A required class was missing while executing com.qulice:qulice-maven-plugin:1.0-SNAPSHOT:check: org/eclipse/aether/util/filter/ExclusionsDependencyFilter. It is possible that I did something wrong in that part of the PR, but my Maven knowledge is not enough to investigate it.

@MikailBag MikailBag marked this pull request as ready for review May 15, 2024 15:55
@MikailBag MikailBag changed the title Prepare for next qulice-maven-plugin release Remove excessive excludes for duplicate finder May 15, 2024
@yegor256
Copy link
Owner

@pnatashap what do you think about this one? Good to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants