New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depositor obtains BaseWrapper balance on pull deposit #533

Open

skeletor-spaceman opened this issue Apr 13, 2022 · 1 comment

skeletor-spaceman commented Apr 13, 2022

afterBal should be changed to deposited

yearn-vaults/contracts/BaseWrapper.sol

Line 182 in b3f33bd

    
           if (depositor != address(this) && afterBal > 0) SafeERC20.safeTransfer(token, depositor, afterBal);

also, pull boolean should be immutable, not sure there is a usecase for both pull and non-pull deposits

westonnelson commented Apr 16, 2022

I agree this is a bit confusing: perhaps using updatedBal or depositorBal might make this even more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment