Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Document how to remove patches #4890

Open
2 tasks done
gruckion opened this issue Sep 23, 2022 · 6 comments · May be fixed by #6470
Open
2 tasks done

[Feature] Document how to remove patches #4890

gruckion opened this issue Sep 23, 2022 · 6 comments · May be fixed by #6470
Labels
documentation This issue or pull request is about the documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gruckion
Copy link

gruckion commented Sep 23, 2022 •
edited
Loading

  • I'd be willing to implement this feature (contributing guide)
  • This feature is important to have in this repository; a contrib plugin wouldn't do

Describe the user story

Yarn offers a way to apply patches with yarn patch and yarn patch-commit. Having used the feature I like it and the document is pretty good. But it is not at all clear how we remove a patch?

https://yarnpkg.com/features/protocols#patch

Describe the solution you'd like

Please provide instructions on how we remove an applied patch.

Describe the drawbacks of your solution

I found myself having to delete .yarn .yarn-lock and my .yarnrc file along with the "resolution" block in package.json manually. Was awful as I then add to set the yarn version, install all the plugins again manually and then run my yarn dlx to setup typescript / vscode.

Describe alternatives you've considered

Using version control carefully to revert the change, and ensure .yarn is not excluded with .gitignore.
@gruckion gruckion added the enhancement New feature or request label Sep 23, 2022
@RDIL RDIL changed the title [Feature] [Feature] Document how to remove patches Sep 24, 2022
@RDIL
Copy link
Member

RDIL commented Sep 24, 2022

Just remove the resolution and delete the file in your patches folder.

@RDIL RDIL added documentation This issue or pull request is about the documentation help wanted Extra attention is needed good first issue Good for newcomers labels Sep 24, 2022
@Blueclaus13
Copy link

is this issue donde?

@fernandohjunqueira
Copy link

What is the current status of this issue? Is it done? It looks like removing the resolution and deleting the file in the patches folder does not work. I'd be willing to implement a fix if it is still open.

@RDIL
Copy link
Member

RDIL commented Nov 6, 2023

@fernandohjunqueira what is happening when you try to remove the resolution and delete the patch?

@black7375
Copy link

Can we have patch remove option(-r,--remove)?

@mr-pinzhang
Copy link

Hey, adding a new command to revert the patched marks is really helpful! just like what pnpm does here: https://pnpm.io/cli/patch-remove

@mvarendorff mvarendorff linked a pull request Aug 24, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation This issue or pull request is about the documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: document removing patches mvarendorff/berry
6 participants
@gruckion @mr-pinzhang @black7375 @RDIL @Blueclaus13 @fernandohjunqueira