Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disconnecting a peer while responding crashes the process #23

Open
yangl1996 opened this issue May 14, 2019 · 1 comment
Open

Disconnecting a peer while responding crashes the process #23

yangl1996 opened this issue May 14, 2019 · 1 comment
Assignees
@yangl1996
Labels
bug Something isn't working Demo Useful features for demo Paper Issues to be fixed for the paper
Milestone
Performance exper...

Comments

@yangl1996
Copy link
Owner

The server thread crashes if a peer disconnects when we are in the middle of replying to it. A concrete example is that peer P requests block B, and while we are gathering the data to reply, A disconnects. When we are ready to write the reply message back to P, we have a broken pipe.
@yangl1996 yangl1996 self-assigned this May 14, 2019
@yangl1996 yangl1996 added the bug Something isn't working label May 15, 2019
@yangl1996 yangl1996 added this to the Performance experiment milestone May 16, 2019
@bagavi bagavi added the Paper Issues to be fixed for the paper label Jul 14, 2019
@bagavi
Copy link
Collaborator

bagavi commented Jul 14, 2019

We will need this for large scale tests.

@bagavi bagavi added the Demo Useful features for demo label Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yangl1996 yangl1996

Labels
bug Something isn't working Demo Useful features for demo Paper Issues to be fixed for the paper
Projects
None yet
Milestone
Performance experiment
Development

No branches or pull requests
2 participants
@bagavi @yangl1996