Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you come up with a comfy ui version #14

Open
Jerry-155 opened this issue Oct 18, 2024 · 20 comments
Open

Can you come up with a comfy ui version #14

Jerry-155 opened this issue Oct 18, 2024 · 20 comments

Comments

@Jerry-155
Copy link

No description provided.

@Hsshebb
Copy link

Hsshebb commented Oct 25, 2024

+1

@zmwv823
Copy link

zmwv823 commented Oct 27, 2024

Emmm, seems not much diffrent.

test-inpaint

canny-test
8b69ee)

depth-test

normal-test

@Hsshebb
Copy link

Hsshebb commented Oct 27, 2024

Hey, @zmwv823 It's great news that we have Ctrl lora nodes and appreciate that here you have compared them with CNs with 1.5 checkpoints. However, you have tested Ctrl lora only with Dreamshaper, why? Is it the only supported model? While you have used different checkpoint with normal CN with 1.5? Can you please do a comparison with same checkpoints so we have a even better idea. Otherwise it just seems normal like sd 1.5 CN.

@zmwv823
Copy link

zmwv823 commented Oct 27, 2024

Hey, @zmwv823 It's great news that we have Ctrl lora nodes and appreciate that here you have compared them with CNs with 1.5 checkpoints. However, you have tested Ctrl lora only with Dreamshaper, why? Is it the only supported model? While you have used different checkpoint with normal CN with 1.5? Can you please do a comparison with same checkpoints so we have a even better idea. Otherwise it just seems normal like sd 1.5 CN.

At beginning i forget to use the same checkpoint.
Ctrlora works with almost any sd1.5 checkpoint.
The result with different ckpt relate to the checkpoint style.

Below is comparison to all sd1.5 controlnet models stored on my pc.

  • Seg:
    Seg
  • Depth:
    Depth
  • Canny:
    Canny
  • Lineart:
    Lineart1
    Lineart2
  • Normal:
    Normal
  • Openpose:
    Openpose

@Jerry-155
Copy link
Author

How to get ctrlora's nodes

@Jerry-155
Copy link
Author

How to get ctrlora's nodes

@zmwv823

@zmwv823
Copy link

zmwv823 commented Oct 29, 2024

How to get ctrlora's nodes

@zmwv823

  • Not planned to upload to github, because i'm waiting for comfy official support for ctrlora, max 2 loras the same time in this repo, while in comfy we can apply multi controlnets.
    image

@Jerry-155
Copy link
Author

ok,fine

@zmwv823
Copy link

zmwv823 commented Oct 29, 2024

ok,fine

My fault, it works with multi conditioning, just some codes need modified.

image

@Jerry-155
Copy link
Author

So you're going to publish it? @zmwv823

@Jerry-155
Copy link
Author

The official gradio interface is always wrong, I wish I could run it on comfy ui!

@zmwv823
Copy link

zmwv823 commented Oct 29, 2024

The official gradio interface is always wrong, I wish I could run it on comfy ui!

The gradio demo can be modified to use comfy checkpoints、controlnet_models and comfyui_controlnet_aux (detection_models) models if u konw some python codes.

Emmm, multi conditioning needs a lot modification on now codes, i'll consider publish it if all debug passed.

@Jerry-155
Copy link
Author

ok thanks

@zmwv823
Copy link

zmwv823 commented Oct 29, 2024

ok thanks

I don't know how to write javascript to hide node_parts for simplify the nodes.

  • With 7 loras

image

  • 2 loras

image

  • 3loras

image

@Jerry-155
Copy link
Author

You can ask chatgpt, I always do it @zmwv823

@Jerry-155
Copy link
Author

Is it a problem with the checkpoints, and why do you come out with a poorly textured image @zmwv823

@zmwv823
Copy link

zmwv823 commented Oct 29, 2024

Is it a problem with the checkpoints, and why do you come out with a poorly textured image @zmwv823

Maybe it's designed for 2 loras or lora_weight is too high or too much loras applied.

U can try it by yourself, i opened a custom_node repo for this project:

@Jerry-155
Copy link
Author

Okay, I'll try it.

@toyxyz
Copy link

toyxyz commented Nov 6, 2024

@zmwv823
Copy link

zmwv823 commented Nov 6, 2024

Kosinkadink/ComfyUI-Advanced-ControlNet#193

Waiting for it, since it's ldm based (it's beyond my knowledge), should be easy to adapt to comfy (ldm based).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants