Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve package test #5945

Open
star-hengxing opened this issue Dec 7, 2024 · 6 comments
Open

Improve package test #5945

star-hengxing opened this issue Dec 7, 2024 · 6 comments

Comments

@star-hengxing
Copy link
Contributor

Is your feature request related to a problem? Please describe.

N/A

Describe the solution you'd like

  • Test package .pc

Describe alternatives you've considered

No response

Additional context

No response

@waruqi
Copy link
Member

waruqi commented Dec 8, 2024

这个怎么测

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


How to test this

@star-hengxing
Copy link
Contributor Author

可以在 xmake/modules/private/action/require/impl/actions/test.lua 添加 _test_pkgconfig 函数

  • 检测 includedirs/links 是否和 package 匹配,预防一些 corner case(libxml2/x264)。
  • 检测 package:name 和 pc file name 是否一样,如果不一样可以在 verbose 下打印提醒。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


You can add the _test_pkgconfig function in xmake/modules/private/action/require/impl/actions/test.lua

  • Check whether includedirs/links matches package to prevent some corner cases (libxml2/x264).
  • Check whether package:name and pc file name are the same. If they are different, you can print a reminder under verbose.

@waruqi
Copy link
Member

waruqi commented Dec 15, 2024

这种感觉只能加 warning 要是直接 abort 估计得 break 一堆包,而且很多包 有很多的子库,和多个 pc 的,全是跟包名不同的 怎么搞,比如 abseil

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


This feeling can only be added with warning. If you directly abort, you will probably have to break a bunch of packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants