Add PHPUnit testing setup for PHP 7.3. #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, PHP 7.4 has suitable SQLite version: Should we upgrade our default PHP version now to get rid of this? https://github.com/wunderio/drupal-project/blob/feature/lando-phpunit-php-7.3/.lando/phpunit.sh#L10-L15 |
|
Closing in favour of #122 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work is mostly based on https://agile.coop/blog/drupal-phpunit-tests-lando/. I had to upgrade SQLite version by using
.lando/phpunit.shbecause of outdated SQLite, see https://www.drupal.org/project/drupal/issues/3107155#comment-13523654. Will try to upgrade PHP to 7.4 in another PR to see if it has more recent SQLite and decide, should we upgrade our default PHP version.@guncha25, this probably fixes #73.