Add support for multiline postinstall and postupgrade commands #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jancis
requested changes
Nov 3, 2022
There was a problem hiding this comment.
Thank You! I was able to reproduce this issue. I tested this change, toYaml generates extra | symbol and it creates incorrect resource template:
command: ["/bin/bash", "-c"]
args:
- |
|
echo Postinstall command executed
ls -Al
echo another command
|
echo Postupgrade command executed
ls -Al
echo another command
The solution is to remove toYaml and keep nindent
{{- $service.postinstall.command | nindent 10 }}
This generates correct template:
command: ["/bin/bash", "-c"]
args:
- |
echo Postinstall command executed
ls -Al
echo another command
echo Postupgrade command executed
ls -Al
echo another command
Jancis
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245