New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Data" field for providing additional check information #136

Open

davegaeddert opened this issue Dec 5, 2017 · 0 comments

Labels

Contributor

davegaeddert commented Dec 5, 2017 •

edited

Loading

What I was looking for originally was a way to get more information on certain failed checks, particularly the ones where the extra detail (like which PHP files were found in uploads) won't fit nicely in a shorter-style summary "message".

Oh right. I was thinking these could go in a data field (or something better named). I think it needs to be in a separate field though, because it could be a huge amount of data and probably wouldn't be something you want to try to parse out of a message.

Can you give an example of what would be in the data field for the php-in-upload check? Would it be the file paths separated by newlines?

It would be the file path relative to WordPress root in JSON format. In --format=table, the JSON would be rendered within the table. In --format=json, it would be true JSON.

From discussion in #131

davegaeddert mentioned this issue

Add recommendation field and write Plugin_Update recommendation #131

Closed

danielbachhuber added the command:doctor label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment