Missing social icons

[nbradbury]

Fixes #21490

Our social feature was missing icons for Bluesky, Nextdoor, and Threads. This PR adds the missing icons, and also adds a generic icon for services that don't have an icon in the future.

To test:

• My Site > More > Social
• Verify the icons appear correctly

To view the icons as they appear when enabled, you can change this line from > 0 to == 0.

[dangermattic]

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21492-976f972
	Commit	976f972
	Direct Download	wordpress-prototype-build-pr21492-976f972.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21492-976f972
	Commit	976f972
	Direct Download	jetpack-prototype-build-pr21492-976f972.apk

Note: Google Login is not supported on these builds.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.44%. Comparing base (61d36ee) to head (976f972).
Report is 24 commits behind head on trunk.

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #21492   +/-   ##
=======================================
  Coverage   39.44%   39.44%           
=======================================
  Files        2121     2121           
  Lines       99564    99564           
  Branches    15313    15313           
=======================================
  Hits        39277    39277           
  Misses      56806    56806           
  Partials     3481     3481           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dcalhoun]

Thanks for addressing this. 🙇🏻‍♂️

These icons are better than an empty space. However, I can't help but note that all the existing icons are contained within a filled circle. Ideally we update this for consistency at some point.

[nbradbury]

I can't help but note that all the existing icons are contained within a filled circle. Ideally we update this for consistency at some point.

I'm not sure we can. Nextdoor's brand guidelines state, "Nextdoor trademarks must be used as provided by Nextdoor with no modifications." Instagram is similar, "Anyone using Instagram’s assets should only use the logos and screenshots found on our Brand Resource Center site and follow these guidelines."

[dcalhoun]

Nextdoor's brand guidelines state, "Nextdoor trademarks must be used as provided by Nextdoor with no modifications." Instagram is similar, "Anyone using Instagram’s assets should only use the logos and screenshots found on our Brand Resource Center site and follow these guidelines."

Sure. We could either ignore the guidelines or remove the existing modifications—i.e., the circles surrounding all other logos. I'd be fine with the latter.

Side note: I'm sure these companies' brand guidelines likely include information discouraging colorizing the logos, which we are doing based on each connection's status.

[nbradbury]

Should we attempt to downsize this?

Good call. I reduced it to 64 x 64.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud