Skip to content
This repository has been archived by the owner on Jul 27, 2019. It is now read-only.

Merge plugin #45

Open
hugoblanc opened this issue Jul 17, 2019 · 2 comments
Open

Merge plugin #45

hugoblanc opened this issue Jul 17, 2019 · 2 comments

Comments

@hugoblanc
Copy link

hugoblanc commented Jul 17, 2019

Is your feature request related to a problem? Please describe.

Ionic users are all using the good old cordova-plugin-firebase Ionic Native firebase

Which is not a good solution as described here: Issue 3038

Your repository and the dpa99's repository are trying to achieve the same thing.

Describe the solution you'd like

Merge both repository would be ideal.

Describe alternatives you've considered

Not merge, and create an ionic native "plugin" with only one repository. This solutions leads to dupplication of solutions and the end of the unchoosen plugin, which is sad as you both seems invested into this plugin.

Additional context

I also posted on dpa99 repo

@newuser44
Copy link

I think more the ionic documents need to be updated to push people to the new way.

@sagrawal31
Copy link
Member

Hi @hugoblanc, we are more than happy to archive this repository and send users to dpa99 repo. I understood your concern about users diverting to two different repositories and about Ionic native wrapper towards it.

Yes, our starting intention was to fix the build due to Firebase breaking release and later on we started maintaining it with some small & breaking changes (to use latest versions).

But I'm concerned about the Ionic's native wrapper of this plugin. In the recent releases of Dave, he has changed the name so I think, those will not work with TypeScript Ionic wrapper so it would be problematic for Ionic developers to use that version. Correct me if I'm wrong.

So what we can do, we can freeze this repository in the current version so Ionic 3 users can also use it along and later Dave can also fork & update the APIs in the Typescript wrapper and he can keep maintaining his repository.

Please, let me know your thoughts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants