Consider treating cloudflare:sockets as external in rollupOptions set in @astrojs/cloudflare

[irvinebroque]

Describe the Bug

When people try to build Astro apps that use the Postgres.js driver, they see this error at build time:

Error: Cannot resolve "cloudflare:sockets" from "...\node_modules\.pnpm\[email protected]\node_modules\postgres\cf\polyfills.js" and externals are not allowed!

https://x.com/masylum/status/1839743841252905467

Yes — people can fix this in userland by explicitly setting their vite config to treat cloudflare:sockets as external:

vite: {
  ssr: { external: ['node:buffer', 'node:events', 'cloudflare:sockets', 'node:stream' ] },
  build: { rollupOptions: { external: ['cloudflare:sockets'] } },
},

If I understand the adapter correctly, it seems like there is an opportunity here to do this for people automatically, and reduce confusion and take this problem out of userspace?

https://github.com/withastro/adapters/blob/main/packages/cloudflare/src/index.ts#L246

Participation

• I am willing to submit a pull request for this issue.