Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this package dead/abandoned? #257

Open
jordie23 opened this issue Jun 17, 2022 · 19 comments
Open

Is this package dead/abandoned? #257

jordie23 opened this issue Jun 17, 2022 · 19 comments

Comments

@jordie23
Copy link

No updates since 2021, many open issues. Anyone know if there's a fork or another maintained package?

@Kreeg
Copy link

Kreeg commented Jun 23, 2022

The author himself made the last commit a year ago. It more likely to be abandoned. The good news is we can fork this and do necessary updates by our self.

@Brianzchen
Copy link

There's also a bug on ios with a fix that hasn't been merged. So I conclude yes unfortunately

@Kreeg
Copy link

Kreeg commented Jul 8, 2022

@willmcpo @jvitela Hi! Do you have any plans for this project? If no - maybe you should create a team to collaborate on this? I'm sure there are people interested in this.
Yes, technically we can fork to own repo, but if there will be no support for this project from the dev team, it's better to transfer this repo to interested people

@jvitela
Copy link
Contributor

jvitela commented Jul 8, 2022

Hi @Kreeg, I am not a maintainer of this library and I am no longer working with it. @willmcpo doesn't seem active on Github since 2021.

@kosmeln
Copy link

kosmeln commented Jul 29, 2022

Could anybody recommend a decent alternative? I've browsed a few, but was unsure there is a bulletproof one - especially with all iOS concerns.

@fjeldsoe
Copy link

fjeldsoe commented Aug 5, 2022

@kosmeln It's coming to CSS in the near future: https://developer.mozilla.org/en-US/docs/Web/CSS/overscroll-behavior

@kosmeln
Copy link

kosmeln commented Sep 23, 2022

@fjeldsoe , thanks a lot!

@sancarr
Copy link

sancarr commented Oct 7, 2022

@kosmeln This seems to work well and address all iOS concerns as well: https://github.com/tuax/tua-body-scroll-lock

@i3web
Copy link

i3web commented Oct 31, 2022

@kosmeln It's coming to CSS in the near future: https://developer.mozilla.org/en-US/docs/Web/CSS/overscroll-behavior

thanks a lot ! it works well.

@krutoo
Copy link

krutoo commented Nov 11, 2022

@kosmeln It's coming to CSS in the near future: https://developer.mozilla.org/en-US/docs/Web/CSS/overscroll-behavior

It's great but many iOS users still uses old iOS/Safari

Can someone recommend alternative library that works with older and newer iOS Safari?

@rick-liruixin
Copy link

They stopped maintenance. I had to work it out myself, using the same approach, with a new version of typeScript. And fix the original problem, available for everyone to use.

npm i body-scroll-lock-upgrade

@KilianSSL
Copy link

KilianSSL commented Apr 26, 2023

@krutoo I ended up using tua-body-scroll-lock, it's inspired by body-scroll-lock and works as intended. I'd strongly discourage anyone from using body-scroll-lock any further.

@Brianzchen
Copy link

@KilianSSL Can you link the npm package? Can't seem to find it

@KilianSSL
Copy link

I've fixed the name, sorry for that...

@Kreeg
Copy link

Kreeg commented Apr 28, 2023

tua-body-scroll-lock was updated 2 years ago. It seems to be abandoned too

@simonmaass
Copy link

simonmaass commented May 16, 2023

anyone find a good alternative?

Found these:

Does anyone have experience or can recommend something?

@krutoo
Copy link

krutoo commented Jul 10, 2023

@simonmaass i tried https://github.com/rick-liruixin/body-scroll-lock-upgrade and it seems to work well for me

@dangelion
Copy link

On July 2024 overscroll-behavior has 95% usage
https://caniuse.com/css-overscroll-behavior
I think it's time to adopt that and abandon all these junky JS hacks.

Here's a good reference
https://ishadeed.com/article/prevent-scroll-chaining-overscroll-behavior/

@thisisjamessmith
Copy link

thisisjamessmith commented Sep 28, 2024

On July 2024 overscroll-behavior has 95% usage https://caniuse.com/css-overscroll-behavior I think it's time to adopt that and abandon all these junky JS hacks.

Here's a good reference https://ishadeed.com/article/prevent-scroll-chaining-overscroll-behavior/

Seems like overscroll-behavior is still not quite ready for production usage. The author of that article (and a great article it is too!), casually dismisses one of the major drawbacks:

An interesting thing to keep in mind though is that when the navigation is short (and thus isn’t scrollable), and a user tried to scroll for no reason, the body will scroll, even if overscroll-behavior-y: contain is set.
...
Unfortunately, I’m not aware of a fix for that other than the “hacks” introduced at the beginning of the article.

It's pretty critical to be able to lock the body scroll when a modal/dialog is in the top layer, regardless of how much content is inside. I'm mostly using Tua Body Scroll Lock at the moment, which is doing the job well, but would be great to abandon it . There's a good thread about all of this at WhatWG here, along with some interesting alternative approaches: whatwg/html#7732 ... in particular this sounds like an interesting idea (haven't tried it myself yet though): whatwg/html#7732 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests