Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify PR template #682

Open
transiient opened this issue Mar 1, 2020 · 3 comments
Open

Simplify PR template #682

transiient opened this issue Mar 1, 2020 · 3 comments
Assignees

Comments

@transiient
Copy link
Collaborator

Too many people are totally ignoring the template. How's this for a new one? Assigned myself to this issue as I'll implement the changes, but I'd like a bit of feedback first.


uses.tech Pull Request

Adding to data.js

  • Your URL MUST be a /uses URL. Any pull requests without a /uses URL will be removed
  • Follow the naming and style conventions of other entries
  • Only commit necessary files
  • Please name this PR "Add John Doe", replacing "John Doe" with your own name

Adding code fixes

  • Ensure only necessary files are committed
  • Follow naming and style conventions of existing code
  • Use descriptive names for commits
  • Ensure this pull request has a relevant and informative title
@transiient transiient self-assigned this Mar 1, 2020
@HugoDF
Copy link
Collaborator

HugoDF commented Mar 1, 2020

Looks good to me

@transiient
Copy link
Collaborator Author

@wesbos if I update the PR template, do you want me to keep it commented?

@wesbos
Copy link
Owner

wesbos commented Apr 9, 2020

yes please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants