What kind of weed was the author of this lab smoking?? #3
Comments
The comment mentioned in the codelab was missing. See #3 for details
|
The missing comment has been added to app.js at the appropriate place. Sorry about the mistake of function arrow in the codelab instructions. We'll update that ASAP as well. |
|
What about the other confusing comments like: The Walkthrough (https://webrtc.org/getting-started/firebase-rtc-codelab) has not mentioned that. |
|
Not to mention the fact that the addition of the code that starts with "const offer = roomSnapshoot..." is very unclear about where to put it. It's in the topic of Join Room, but no clear indication of where it goes. If it's simply added to Create Room, the "offer" var has to be renamed and the roomSnapshot is null, causing an error. This kind of stuff really is rendering this entire walkthrough pretty useless. I'm not a rookie in the business by no means but I am very new to this topic so walkthroughs are incredibly important. |
|
@miguelcastro67 I hear your concerns, but I don't agree with your opinion that the codelab is useless. There are room for improvements, and we'll continue to work on this. |
|
I know I came in strong but the fact is that there are not nearly enough step by step directions for someone coming into this tech fresh to even get it working. Where to put that piece of code that invalidly resets that constant and references a null object is an example. I had to make an educated guess on that and I’m still unclear about if I got it right. Until the lab actually works by simply following the steps given with no guesses on the dev’s part, it’s simply incomplete and non functioning. Look I know these things are not merely no brainers to put together. Trust me, I wrote online courseware. But it just seems as if this was scotch-taped together without a lot of effort. All this being said, please let me know if I can be of help. If you think it would help, I’d be happy to arrange everything I think is wrong. I think this tech has a lot promise and should be looked at closely by more people.
Miguel
…---------------------------------------
Sent from my phone
Please excuse any boneheaded errors or random curses.
Miguel A. Castro
President & Principal Consultant
Melvicorp LLC
Twitter: @miguelcastro67
Also a Pluralsight author!
On Feb 25, 2020, at 2:57 AM, Erik Hellman ***@***.***> wrote:
@miguelcastro67 I hear your concerns, but I don't agree with your opinion that the codelab is useless. There are room for improvements, and we'll continue to work on this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Completely agree with @miguelcastro67 ! Especially, since this is linked on webrtc.org as "Get Started" guide - assuming no prior knowledge, nearly no beginner would ever get this running. |
|
Erik, do you have any idea when you'll be posting a working Code Lab? I'm really not going to be able to recommend this technology to my client if I can't educate myself on it; and I can't with the current state of the Code Lab. In all honesty, you need to go through it step by step and I think you'll notice where the lab instructions and the starter code do not sync. Lot's of confusing comments, comments for which you have no implementation, and implementation for which you have no comments. It truly is not workable at all in its current state. Thanks. |
|
The best part is where it says "we will secure the database later" and I am still waiting for that, also what about the part of deploying and hosting from firebase ? |
|
Well I certainly didn’t mean to start a shitstorm but I think it’s easy to see that there are more than just myself that would like to get this usable. It’s a pretty new tech even for seasoned devs. And it’s certainly not intuitive enough that it can just be figured out. I think a good and working walkthrough and sample project is crucial. What do you say, Erik? |
|
I'm not actively involved in this project myself anymore, so I don't have much time to spend on this. The owners of the project are aware of this and hopefully will address that as soon as possible. |
|
The paste in code from the codelab is also filled with the same "->" typo |
|
Can anyone please help me out? Where do we even call the collectICECandidates function mentioned in the last step? Also what do we send as the local and remote parameters to the function? |
|
Here is the code that works! Edit: This only fixes the UI not the stream |
|
You know, I don't really know where these functions are being called |
|
As for the latter part I had to deploy for the scripts to work on other devices |
|
I think there is an error however with how the collectIceCandidates function is implemented as @py-zoid mentioned. I enter in the same room ID but do not see the other devices' stream... |
|
Have you tried looking here? I am trying to just go through their docs and figure it out myself. As it's been over a month since any of the authors/owners made any changes to this repo |
|
Ok so localName and remoteName are just strings that reference the collection in the room documents, for some reason there are no collections in those documents. I am running the collectIceCandidates function at the end of the joinRoomById function There are no errors. However, I don't see the stream of other device on my laptop screen and vice versa. There are no errors but no actual connection either. The Friebase database shows that an answer and offer have been sent and recieved. Its a whole mess :( |
|
@py-zoid I noticed you deleted a few of your comments... did you fix the issue? |
|
@cybertheory I don't think what I mentioned before was the issue. If you just want the solution to this codelab, it's under the solution thread of this repo. |
|
Hello, so I was also trying the codelab. I found it absolutely impossible to use. I was wondering if someone found the good code? |
|
does anyone have a working project incl. server? |
|
any updates on this one? |
|
yes, the solution branch seems to work, at least locally |
|
well for me the solution branch also not working, when ever i am creating a room it works fine but when i try to join this room by using its id on another window it shows that roomSnapshot does not exists |
|
I'm also facing a similar issue than @Umair115, in the sense that I'm able to create a room and join it once. Attempting to join again after reloading the page or from a different browser/device will perform a PeerConnection creation but not change the status to connected, therefore not displaying any streamed video. |
|
I just resolved that error, now this thing is working fine on local means
if u connect it on another browser window it is displaying the remote video
…On Apr 15, 2020 7:09 PM, "Adrian Lopez" ***@***.***> wrote:
I'm also facing a similar issue than @Umair115
<https://github.com/Umair115>, in the sense that I'm able to create a
room and join it once. Attempting to join again after reloading the page or
from a different browser/device will perform a *PeerConnection creation*
but not change the status to *connected*, therefore not displaying any
streamed video.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ7BIT3QNBHAEFZNVA4XMBTRMW5X5ANCNFSM4KYT6D3Q>
.
|
|
@AdrianLopezMuller I think this sample code is a one use only for each room. The room gets deleted once someone hangs up so you can't rejoin it through a refresh or from another device. |
|
well you are right also this code as some issues in creating a connection,
sometime it is connected very easily sometime it is not, i already tried
removing icecandidate numbers ,it is still not working i was thinking to
use a turn server now
…On Thu, Apr 23, 2020 at 7:45 AM Michael Powers ***@***.***> wrote:
@AdrianLopezMuller <https://github.com/AdrianLopezMuller> I think this
sample code is a one use only for each room. The room gets deleted once
someone hangs up so you can't rejoin it through a refresh or from another
device.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ7BIT37ECNYXO4VQ5436UTRN6TVHANCNFSM4KYT6D3Q>
.
|
|
@powerspowers Thanks for the heads up! |
|
No i found some blogs in which multiple people can join together but
regarding refreshing stuff i don't think so i found any blog
…On Apr 23, 2020 3:19 PM, "Adrian Lopez" ***@***.***> wrote:
@powerspowers <https://github.com/powerspowers> Thanks for the heads up!
Do you know of any other demo where multiple calls can be placed at the
same time and reconnecting to the same room is possible? It doesn't need to
use firebase in any case.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ7BIT3SFHO6NK4SH6WRQATROAI4HANCNFSM4KYT6D3Q>
.
|
|
@Umair115 Hey, that sounds great. Do you mind linking the blogs to take closer look? |
|
Though the guide could certainly be improved, this guide did help me learn a lot of core concepts, as well as a lot of ya'll conversation here. Hopefully it can get updated and improved. Not a lot of WebRTC content out. (atleast compared to what I'm typically involved in, Angular, RxJS, Firebase ) so this is pretty much gold. Make it shiner! |
|
I used this code to create https://twisty.io with persistent rooms, room URLs, shorter IDs and either person can start a call. This code project helped a TON. |
|
Perhaps you should share how you addressed all the points and concerns stated by contributors to this thread. I’m sure everyone would appreciate it,
…Sent from my iPad Air
On May 6, 2020, at 8:39 PM, Michael Powers ***@***.***> wrote:
I used this code to create https://twisty.io with persistent rooms, room URLs, shorter IDs and either person can start a call. This code project helped a TON.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
The solution branch in the code works out of the box once you deploy it on Firebase. That helps as you go through the tutorial as a reference. When you first make a Firebase project the datastore rules are set to allow anyone to read, write objects and collections. Thats obviously not something you want long term so you have to go look up datastore security rules to limit writing to just your domain or if you add authentication (e.g. gmail or facebook which are built into Firebase under the authentication tab) you can limit writing to just logged in users. Now this codebase doesnt really work for Safari and iOS Safari since they dont seem to like the addTrack calls. I posted the solution to this in another issue so you can pull that fix from there. Other than those issues the code sample works out of the box and then for me it was just a matter of starting to separate out the room creation from jumping into a room. I also added a shorter ID for naming rooms. There is a ton more to do to get it where I want it on Twisty (e.g. rejoining rooms, good response if a connection drops, etc) but I found this code solution to be a great start for a simple 1:1 calling system. If you run into issues keep posting new issues on this project and I will do my best to answer them. |
|
Hi powerspowers, Is twisty made to help us move forward with our own projects. Will you be making available the webrtc implementation please ? atm i believe its in your firebase functions. |
|
All the WebRTC back and forth is in the app.js file actually. There is a lot more that has to be coded to do something intelligent with lost connections and when one party hangs up or tries to reconnect. The firebase functions create new room IDs and also sort out who is the caller and who is the callee (special signaling logic). My plan is to release a free REST API so that anyone can use it to develop their apps. (preview it by going to https://twisty.io/t/createroom - it will return JSON for success, roomid and roomurl). You could embed the room URL inside an iframe to use a room within your web site or app. <iframe allow="camera; microphone; autoplay" src="https://twisty.io/shortid"></iframe>I think I could do some updates to the original FirebaseRTC project that would help everyone new to coding webrtc. I'll see if I can do a pull request and make some updates. |
|
It would be great and pretty much helpful for the new comers also if you
want any help, feel free to ask, i will try my best to help you as much as
i can
…On Sun, May 10, 2020 at 3:48 PM Michael Powers ***@***.***> wrote:
All the WebRTC back and forth is in the app.js file actually. There is a
lot more that has to be coded to do something intelligent with lost
connections and when one party hangs up or tries to reconnect.
The firebase functions create new room IDs and also sort out who is the
caller and who is the callee (special signaling logic). My plan is to
release a free REST API so that anyone can use it to develop their apps.
(preview it by going to https://twisty.io/t/createroom - it will return
JSON for success, roomid and roomurl).
You could embed the room URL inside an iframe to use a room within your
web site or app.
<iframe allow="camera; microphone; autoplay" src="
https://twisty.io/shortid"></iframe>
I think I could do some updates to the original FirebaseRTC project that
would help everyone new to coding webrtc. I'll see if I can do a pull
request and make some updates.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ7BIT4H3773A6VZGYIINSLRQ2BADANCNFSM4KYT6D3Q>
.
|
|
I see that although there is a Feb 21 comment saying that the "->" would be changed to "=>" in the codelab documentation, here it is almost 10 months later and the same error is still there. The instructions are still a mess--very unclear where things should get pasted. Someone who knows what they are doing could fix the errors, clarify the codelab, and fix the source so that it all fits together in an afternoon, and still have plenty of time to play video games. Not sure what to make of the fact that this seems to have such low priority, but it is too bad. |
|
@powerspowers I see a reference to this in another issue, but I don't see a solution posted. Can you let us know where to find it? Thanks
|
I could not make it work between laptop and phone |
|
Does Twisty.io work between phone and laptop. I believe it should. Planning
to release it soon
…On Sat, Dec 5, 2020 at 11:31 AM Kemal Onyurt ***@***.***> wrote:
I used this code to create https://twisty.io with persistent rooms, room
URLs, shorter IDs and either person can start a call. This code project
helped a TON.
I could not make it work between laptop and phone
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABLMIPCUEJBHL7IF2VFHTTSTKRDZANCNFSM4KYT6D3Q>
.
|
|
The solution doesn't work and the arrow function is still broken on master. Waste of time. |
@meldaravaniel I misunderstood this and thought you were inviting PR's for your repo, so I submitted one. There were still a couple of errors to clean up, and some other suggestions. Thank you so much for doing this, I was finally able to make sense of it! |
|
sincely this what i get after trying to create a room |
The comment mentioned in the codelab was missing. See webrtc#3 for details
|
Besides the simple arrow function syntax of "-> to =>" till the "snapshot" variable not being used, along with no mention of where the commenting has ended and also having the additional comments, I am surprised that this codelab exists (with these many errors), on the webrtc official site! Other than that, it took me more than 4 hours to figure out and take a calculated guess on what peerConnection variable was being used for! This surely has to be checked by people concerned! |
|
Coming to this 4 years later (from the original issue) where it states the -> to => issue will be fixed, along with the documentation being cleaned up to hopefully make sense, this is extremely frustrating.
|
|
Given the total lack of interest from people who know both Firebase and WebRTC (if such exist) in fixing this, are we better off deleting the tutorial? (if someone feels like fixing it, please send patches - but at the moment I don't know of a person who a) knows both WebRTC and Firebase, and b) cares) |
and others
Jeez, where to start.
The easy thing is fixing the obvious syntax error of -> to =>.
But the walk-through and the code are totally out of sync.
The create a room code is easy enough to put where the comment says, though again, out of sync with the directions. Then it starts to get confusing cause the walk-through talks about adding the code to join a room but doesn't specify where to put it. Adding it immediately after the "create" code ain't working. Another error that comes up is the fact the roomSnapshoot variable is being used but not defined. This whole thing needs to be re-looked at and the author needs some lessons in how to properly teach. Putting the final code somewhere in this repo would be nice.
The text was updated successfully, but these errors were encountered: