[LayoutNG] Don't allow line height quirk inside list items. #14623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 20, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1379897
branch
2 times, most recently
from
a6caf52
to
556a9e7
Compare
This makes us match legacy engine behavior more closely, and both Edge and Firefox have something similar, although Firefox triggers based on element type (LI), and not display type (list-item). There's currently nothing in the spec [1] that suggests such special behavior for list items. [1] https://quirks.spec.whatwg.org/#the-line-height-calculation-quirk This fix makes the line height differences go away in the test tables/mozilla/bugs/bug23235.html (but note that it will still require a rebaseline, because of minor text rendering differences between legacy and NG). See whatwg/quirks#38 for spec discussion. Change-Id: I396c0c85454feeaa45a0a5953b9e6b7c475d131e Reviewed-on: https://chromium-review.googlesource.com/c/1379897 Commit-Queue: Emil A Eklund <[email protected]> Reviewed-by: Aleks Totic <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Reviewed-by: Emil A Eklund <[email protected]> Cr-Commit-Position: refs/heads/master@{#618304}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1379897
branch
from
556a9e7
to
66d1667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes us match legacy engine behavior more closely, and both Edge
and Firefox have something similar, although Firefox triggers based on
element type (LI), and not display type (list-item). There's currently
nothing in the spec [1] that suggests such special behavior for list
items.
[1] https://quirks.spec.whatwg.org/#the-line-height-calculation-quirk
This fix makes the line height differences go away in the test
tables/mozilla/bugs/bug23235.html (but note that it will still require
a rebaseline, because of minor text rendering differences between
legacy and NG).
See whatwg/quirks#38 for spec discussion.
Change-Id: I396c0c85454feeaa45a0a5953b9e6b7c475d131e
Reviewed-on: https://chromium-review.googlesource.com/c/1379897
Commit-Queue: Emil A Eklund <[email protected]>
Reviewed-by: Aleks Totic <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Cr-Commit-Position: refs/heads/master@{#618304}