Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: entry query should handle non-string entry #484

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

fi3ework
Copy link
Member

Summary

Correctly handle all possible entry types to add entry query. Previously, we can only handle string indeed.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Timeless0911
Copy link
Collaborator

Can we also support EntryDescription in compose bundleless entry?

@fi3ework
Copy link
Member Author

Can we also support EntryDescription in compose bundleless entry?

I don't think user need to use EntryDescription in bundless mode, even in bundle mode for foreseeable usage. We could talk about that in the future.

@fi3ework fi3ework enabled auto-merge (squash) November 27, 2024 08:08
Copy link

codspeed-hq bot commented Nov 27, 2024

CodSpeed Performance Report

Merging #484 will not alter performance

Comparing non-string (e939fee) with main (c11cfbf)

Summary

✅ 5 untouched benchmarks

@fi3ework fi3ework merged commit 7c34973 into main Nov 27, 2024
19 checks passed
@fi3ework fi3ework deleted the non-string branch November 27, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants