fix: file Extension util #606
Merged
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request includes changes to the
packages/utils/src/common/graph/assets.tsfile to improve the handling of asset extensions. The most important changes are the addition of a new utility function to extract file extensions and the enhancement of an existing function to better match asset extensions.Enhancements to asset extension handling:
packages/utils/src/common/graph/assets.ts: Added a new functionextnameto extract the file extension from a filename, ignoring query parameters.packages/utils/src/common/graph/assets.ts: Modified theisAssetMatchExtensionfunction to use the newextnamefunction, allowing it to match asset extensions more accurately.Related Links
close: #586