Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in Safari #13

Open
arguiot opened this issue May 26, 2017 · 6 comments
Open

Doesn't work in Safari #13

arguiot opened this issue May 26, 2017 · 6 comments

Comments

@arguiot
Copy link

arguiot commented May 26, 2017

Will you ever add Safari support, for iPhone for example??

@paperdave
Copy link

i just tried it on ios 12, it does work.

@arguiot
Copy link
Author

arguiot commented Mar 25, 2019

Yeah, Apple improved WebKit’s API on iOS which fixes the bug. I opened this issue 2 years ago, when there was an actual issue.

@arguiot arguiot closed this as completed Mar 25, 2019
@null92
Copy link

null92 commented Jan 9, 2020

Doesn't work on Safari for macOS.

@arguiot
Copy link
Author

arguiot commented Jan 9, 2020

True, the IS_IOS check should include macOS as well

@arguiot arguiot reopened this Jan 9, 2020
@chrisjreber
Copy link

Also having issues with iOS Safari, it works on iPhones but not iPads. Tested with the same version 14.4 in Simulator, multiple iPads & iPhones in Browserstack, and 3 physical devices. Not getting any click/touch events to trigger in the iPad.

@yell0wsuit
Copy link

yell0wsuit commented Sep 18, 2021

I think the new code from Chromium has fixed that problem, but since I don't have iPads so I can't test it.
Edit: after testing, on iOS the game only works for non-Safari browsers like Chrome and Firefox. I'm investigating in my repo to see what is the problem.
Edit 2: worked for Safari browsers on iOS now. But one disadvantage is that you can only touch the game area to control the dino (unlike in old code where you can press anywhere on the screen).
Edit 3: after digging deeper, the problem was var IS_IOS. The old code used implementation that only applies for iOS < 12, that's why on iPad the game isn't working. I also fixed the "touch anywhere" problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants