Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make timeout for inferencing calls configurable #65

Merged
merged 8 commits into from
Oct 12, 2023
Merged

feat: make timeout for inferencing calls configurable #65

merged 8 commits into from
Oct 12, 2023

Conversation

pratyushsingh97
Copy link
Contributor

Background

  • Expose the timeout field in instances to allow more breathing room for the calls to complete

@haodeqi
Copy link
Contributor

haodeqi commented Oct 9, 2023

hi @pratyushsingh97 , thanks for the PR. can you check and see why the integration test is failing?

haodeqi
haodeqi approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@haodeqi haodeqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you Pratyush.

@haodeqi haodeqi merged commit c8d6fe4 into master Oct 12, 2023
3 checks passed
@haodeqi haodeqi deleted the make-timeout-configuarable branch October 12, 2023 16:47
@pratyushsingh97 pratyushsingh97 mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haodeqi haodeqi haodeqi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pratyushsingh97 @haodeqi