Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update numpy to 1.21.0 and add numpy 1.26 for newer versions of python #64

Merged
merged 4 commits into from
Oct 12, 2023
Merged

fix: update numpy to 1.21.0 and add numpy 1.26 for newer versions of python #64

merged 4 commits into from
Oct 12, 2023

Conversation

pratyushsingh97
Copy link
Contributor

@pratyushsingh97 pratyushsingh97 commented Oct 5, 2023 •
edited
Loading

Changes

  • Numpy version 1.20 has installation problems for M1 Macs
  • According to the release note 1.21 includes universal wheels for macOS
  • However, 1.21 is only supported for python versions 3.7-3.9, and numpy version 1.26 contains support for > 3.9. Release note.
  • Support for python 3.9 is maintained, while introducing support for new version of python that customers are using

Verification

  • To verify, I created two conda virtual envs, one with python3.9 and other with python3.10, and verified the successful installation of the dependencies.

@pratyushsingh97
Copy link
Contributor Author

Hey @haodeqi , can you review this PR as well?

@haodeqi haodeqi merged commit e35c6e9 into master Oct 12, 2023
5 checks passed
@haodeqi haodeqi deleted the update-numpy-support branch October 12, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haodeqi haodeqi haodeqi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pratyushsingh97 @haodeqi