Update the navigation section #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeKerscher
requested review from
mattgarrish,
gregoriopellegrino,
clapierre,
madeleinerothberg,
avneeshsingh and
gautierchomel
mattgarrish
reviewed
Nov 23, 2024
| etc.) is important to allow the user to easily access each part of the content. These features are | ||
| both essential for accessibility and very important for all users reading publications. Therefore, | ||
| <p> Navigating a digital publication through a table of contents, an index, by headings, or by direct go to page shortcuts is important to allow the user to easily access each part of the digital publication. These features are | ||
| both essential for accessibility and important for all users reading publications. Therefore, |
There was a problem hiding this comment.
The "proper title selection" phrasing sounds awkward. Could this be written instead as: "Therefore, it is important to clearly communicate what navigation features are available so users can decide if a publication will meet their needs."
| <li data-localization-id="navigation-page-navigation" data-localization-mode="descriptive">A | ||
| page list enables users to navigate directly to pages from the identified print source | ||
| page list enables users to directly go to pages from the identified print source |
There was a problem hiding this comment.
Although split infinitives aren't the end of the world anymore, this one stuck out when I read it. I would drop "directly" from the sentence as it doesn't add anything to the meaning.
|
Hi George, Also repeating "Contains" with every line seems a bit redundant to me. |
clapierre
approved these changes
Nov 25, 2024
…and a colon introducing the list
|
Yes, we should avoid example that indicate presence of sound hazards.
If we want to give an example of no sound hazard, it is ok because publication without any audio will not have sound hazard.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was at it, I tried to address another issue with the language in the navigation. It was aroundthe issue submitted, 469,"Hard to understand navigation.
I reorderd the items toc, index, headings, go to page.
Oh, I added the term go to page. I know this is a reading system function, but the page list must be there in the content. It just felt like something end users would understand.