-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce variables and processing of epub conformance metadata #495
base: main
Are you sure you want to change the base?
Conversation
Ok, Reviewing the original code and the updated code, I se an issue which we didn't really address. In both cases we never did say what this EPUB has been checked against, only if it met the min, met the expected or exceeded. We don't say if it met WCAG 2.0 2.1 or 2.2. Which is a problem since some folks will require WCAG 2.1 AA, where others might require WCAG 2.2 AA. We also don't point out if this EPUB passed EPUB 1.1 or 1.0. Not sure if that is as big a deal as the WCAG version or not. @GeorgeKerscher @gregoriopellegrino what do you all think? Or do we need to discuss this at our next editors call? |
We have this in: Perhaps we should use the word must or strongly advise. |
What version and level it meets comes after those generic statements based on the level it passed. They come after the detailed conformance information heading is inserted; I have "display |
What we learned with publication manifest is that when making algorithms it's really helpful to write some public code to implement the instructions. That way anyone can run some samples through and see what results. I can maybe try and adapt the generator I made to implement the current logic. |
Wow! That would be outstanding! |
I made a few changes in the last commit based on implementing this code:
I also added the missing quotes to the 1.0 xpaths and deleted the extra backet in the certifier xpath so this will also close #511 and #512 |
The one thing that make me unsure about merging this yet is the string that results from extracting the 1.1 conformance statement and using a regex to delete the hyphen from it. The result is that we can't associate a single ID with it. It could be any of the nine strings. Should we list all of these with their IDs or put them in a note? It makes localization a little more complicated as you have to translate the English text to an ID before you can match the localization. It's not like the other instructions that end in an single ID value. |
This pull request implements the processing change I mentioned in #494 (comment)
In addition to what I mentioned there, I noticed a couple of other problems with the processing that I've tried to fix:
We'd probably still need a note where I have the display statement for conformance_str. I don't know how you guys would want to handle that the variable could hold any of the nine statements. It probably requires a different set of strings than the ONIX processing uses, although the end result will be the same strings.
I'm also open to other ways to process the 1.1 strings into the two variables we need. Maybe we just drop the normalize-space call, as otherwise it'd look like any language's string replacement functionality.
Fixes #511
Fixes #512
Preview | Diff