Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear variable assignment #496

Open
mattgarrish opened this issue Nov 27, 2024 · 1 comment
Open

Unclear variable assignment #496

mattgarrish opened this issue Nov 27, 2024 · 1 comment
Labels
a11y-display-techniques-epub Issue with the epub accessibility metadata display techniques a11y-display-techniques-onix Issue with the onix accessibility metadata display techniques

Comments

@mattgarrish
Copy link
Member

In the preprocessing step, it says that package_document_as_text parameter contains the package document as a utf-8 string.

The first step then says:

LET package_document_content be textual representation of the Package document for the publication given package_document_as_text.

I don't follow what this point of this assignment is, though. It's just passing the string from one variable to another. Nothing happens until the next step when package_document_content is parsed into a dom tree.

Unless there's a purpose I'm missing, I'd suggest removing this step and just parsing the text string that's sent to the function.

@mattgarrish
Copy link
Member Author

This also applies to the onix techniques.

@mattgarrish mattgarrish added a11y-display-guide Issue with the UX Guide principles or techniques a11y-display-techniques-epub Issue with the epub accessibility metadata display techniques a11y-display-techniques-onix Issue with the onix accessibility metadata display techniques and removed a11y-display-guide Issue with the UX Guide principles or techniques labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y-display-techniques-epub Issue with the epub accessibility metadata display techniques a11y-display-techniques-onix Issue with the onix accessibility metadata display techniques
Projects
None yet
Development

No branches or pull requests

1 participant