Change vue/order-in-components rule to enforce ordering on slots and expose defaults
#2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
approved these changes
May 12, 2023
There was a problem hiding this comment.
✔️ LGTM!
But since this is a breaking change, maybe we should first release a last v9.x version without this PR merged, so we don't force people to upgrade to a major version to use the new features.
Also, we could think about other breaking changes that we may want to accumulate into one v10 release.
|
Agree with you. I think this PR should be released with v10. |
|
@ota-meshi I changed the target branch to |
ota-meshi
force-pushed
the
order-in-components
branch
from
9c4fe7d
to
225738f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defineSlotsandslotsoption #2125slotstovue/order-in-componentsdefault order #2399