Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prefer-use-template-ref): only check root-level variables #2612

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fix(prefer-use-template-ref): only check root-level variables #2612

merged 2 commits into from
Nov 27, 2024
+107 −61

Conversation

Thomasan1999
Copy link
Contributor

resolves #2607

@FloEdelmann FloEdelmann mentioned this pull request Nov 18, 2024
Merged
@Thomasan1999 Thomasan1999 reopened this Nov 18, 2024
ota-meshi
ota-meshi approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

FloEdelmann
FloEdelmann approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too 🙂

@FloEdelmann FloEdelmann changed the title fix(prefer-use-template-ref): should check only root-level variables fix(prefer-use-template-ref): only check root-level variables Nov 27, 2024
@FloEdelmann FloEdelmann merged commit fdfffd6 into vuejs:master Nov 27, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prefer-use-template-ref: should check only root-level variables
3 participants
@Thomasan1999 @FloEdelmann @ota-meshi