Updating stdlib dependency to latest and add support for puppet 8 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramesh7
force-pushed
the
stdlib-update-version-latest
branch
from
fe0a0c1 to
bb0b09a
Compare
ekohl
requested changes
Oct 17, 2023
| @@ -11,7 +11,7 @@ | |||
| "dependencies": [ | |||
| { | |||
| "name": "puppetlabs/stdlib", | |||
| "version_requirement": ">= 4.13.0 < 9.0.0" | |||
| "version_requirement": ">= 9.4.0 < 10.0.0" | |||
There was a problem hiding this comment.
If you don't make code changes, please don't bump the lower bound. Why specifically 9.4.0 as the lower bound?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues