-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support other versions of remi repo on redhat #669
Open
kobybr
wants to merge
7
commits into
voxpupuli:master
Choose a base branch
from
MiamiOH:support-other-versions-of-remi-repo-on-redhat
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
80d83c9
Support other versions of remi repo on redhat
kobybr d4bc190
Add acceptance
kobybr dc91e82
Fix lint errors
kobybr d0835cf
Remove erroneous require
kobybr 29aa257
Organize acceptance tests
kobybr 8fe7527
Revert to using older param name
kobybr 564f419
Fix idiosyncrasy in repo name
kobybr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'spec_helper_acceptance' | ||
|
||
describe 'with RedHat', if: (fact('os.family') == 'RedHat') do | ||
context 'default parameters' do | ||
it_behaves_like 'an idempotent resource' do | ||
let(:manifest) do | ||
<<-PUPPET | ||
include 'php::repo::redhat' | ||
PUPPET | ||
end | ||
end | ||
describe yumrepo('remi-php56') do | ||
it { is_expected.to exist } | ||
end | ||
end | ||
|
||
context 'with version 7.2' do | ||
it_behaves_like 'an idempotent resource' do | ||
let(:manifest) do | ||
<<-PUPPET | ||
class { 'php::repo::redhat': | ||
yum_repo => 'remi_php72', | ||
} | ||
PUPPET | ||
end | ||
end | ||
describe yumrepo('remi-php72') do | ||
it { is_expected.to exist } | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'spec_helper' | ||
|
||
describe 'php::repo::redhat', type: :class do | ||
on_supported_os.each do |os, facts| | ||
context "on #{os}" do | ||
let :facts do | ||
facts | ||
end | ||
|
||
case facts[:osfamily] | ||
when 'RedHat' | ||
describe 'when called with no parameters on RedHat' do | ||
it { is_expected.to contain_yumrepo('remi-php56') } | ||
end | ||
|
||
describe 'when called with version 7.0 on RedHat' do | ||
let(:params) do | ||
{ | ||
yum_repo: 'remi_php70' | ||
} | ||
end | ||
|
||
it { is_expected.to contain_yumrepo('remi-php70') } | ||
end | ||
|
||
describe 'when call with version 7.1 on RedHat' do | ||
let(:params) do | ||
{ | ||
yum_repo: 'remi_php71' | ||
} | ||
end | ||
|
||
it { is_expected.to contain_yumrepo('remi-php71') } | ||
end | ||
|
||
describe 'when call with version 7.2 on RedHat' do | ||
let(:params) do | ||
{ | ||
yum_repo: 'remi_php72' | ||
} | ||
end | ||
|
||
it { is_expected.to contain_yumrepo('remi-php72') } | ||
end | ||
|
||
end | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.\d$
feels weird: any char followed by a digit at the end of a line.I guess what you mean here is any number of digits at the end of the string?
\d+\z