Add validation of fpm and fpm-pools configuration files #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoneycutt
reviewed
Feb 13, 2020
|
Thanks for the contribution! Could you please add an acceptance test. |
ghoneycutt
reviewed
Feb 13, 2020
| @@ -64,6 +64,7 @@ | |||
| Hash $pools = $php::real_fpm_pools, | |||
| $log_owner = $php::log_owner, | |||
| $log_group = $php::log_group, | |||
| Boolean $disable_configtest = false, | |||
There was a problem hiding this comment.
This would need a spec test to show that validate_cmd is as expected.
There was a problem hiding this comment.
Yes, indeed. I'll add a spec test for this parameter.
bastelfreak
added
needs-work
|
Dear @ffapitalle, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
added 2 commits
June 19, 2020 18:36
Defines validation command for fpm service configuration files, and sets it as a requirement.
This adds the option to enable/disable fpm config file validation.
ffapitalle
force-pushed
the
validate_fpm_config
branch
from
0c19042
to
c7817ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR adds validation check for fpm and fpm pools configuration file before applying changes.
Having introduced a misconfiguration on php-fpm that avoid the service to start normally (
pm.start_servers>pm.max_spare_servers), catalog application was successfull but service failed to restart.