add option for removing cron provided by distro pkgs #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmenuel
force-pushed
the
disable-distro-cron
branch
3 times, most recently
from
ba093e6 to
4a38f2e
Compare
treydock
reviewed
Nov 16, 2022
|
@gmenuel Please address the merge conflicts. |
gmenuel
force-pushed
the
disable-distro-cron
branch
2 times, most recently
from
846846a to
c104f29
Compare
bastelfreak
reviewed
Nov 23, 2022
gmenuel
force-pushed
the
disable-distro-cron
branch
from
c104f29 to
34681cf
Compare
|
I've updated the cron file name for freeBSD. I've don't have a freeBSD to test that it is correct (and I'm not particulary familiar with it) so if anyone can check that this is correct it would be great :) |
gmenuel
force-pushed
the
disable-distro-cron
branch
from
34681cf to
1afbd1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR aims at removing the system cron or systemd timer when the renew cron is managed by puppet (this doesn't handle certonly cron). If we don't do that on certains distro (for exemple Debian), a cron will be automaticaly added by the package and might renew the certificate before the puppet cron, and thus the puppet renew hooks won't be executed.
This Pull Request (PR) fixes the following issues
Fixes #164